feat(aws): CleanupAlarmsAgent with an optional user-defined name pattern (backport #6317) #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
jasonmcintosh
approved these changes
Dec 13, 2024
|
Features cannot be merged into release branches. The following commits are not tagged as one of "fix, chore, docs, perf, test":
Read more about commit conventions and patch releases here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might defined a custom name for the scaling policies and alarms names that dont match the strict namePattern of the AlarmsCleanUp agent.
Especially for custom alarms when a scaling policy is deleted the alarms are not cascade deleted leading to stale cache in the cats_v1_alarms table.
This PR allows the user to define their own AlarmsNamePattern for the AlarmsCleanupAgent
This is an automatic backport of pull request #6317 done by Mergify.