-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): use a connection pool named "read" for some read operations in SqlExecutionRepository #4803
Open
kirangodishala
wants to merge
6
commits into
spinnaker:master
Choose a base branch
from
kirangodishala:use-read-replicas-in-execution-repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhengg
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we include an example (maybe in one of the commit messages or the description) for how to configure orca to use a read pool?
dzhengg
approved these changes
Nov 21, 2024
dbyron-sf
changed the title
feat(sql): use a connection pool named "read" for read operations in SqlExecutionRepository
feat(sql): use a connection pool named "read" for some read operations in SqlExecutionRepository
Nov 21, 2024
… DataSource bean available depending on configuration
kirangodishala
force-pushed
the
use-read-replicas-in-execution-repository
branch
2 times, most recently
from
December 24, 2024 14:38
d2a56fe
to
53927e2
Compare
dbyron-sf
reviewed
Dec 25, 2024
...rc/main/kotlin/com/netflix/spinnaker/orca/sql/pipeline/persistence/SqlExecutionRepository.kt
Outdated
Show resolved
Hide resolved
…SqlExecutionRepository if configured to do so. WIP: so far this is only configuration, nothing actually uses the read pool
…nRepository to pave the way to use the read pool for selecting by correlation id
- correlation ids for completed pipelines/orchestrations - a stage
…selectExecution since it's not used.
kirangodishala
force-pushed
the
use-read-replicas-in-execution-repository
branch
from
December 25, 2024 05:02
53927e2
to
942d48c
Compare
dbyron-sf
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a read pool for some read-only database queries in SqlExecutionRepository. Enable this by configuring an additional connection pool named
"read"
, like this:Additional read-only database queries happen in places that expect to see "just-written" contents. They're not safe to convert to use the read replica until there's logic in place to be aware of replication lag, and wait until the read replica is up-to-date.