-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added latest helm chart, Removed unsupported operator #336
base: master
Are you sure you want to change the base?
Conversation
keerthibingi
commented
Apr 21, 2023
•
edited
Loading
edited
- Added - Spinnaker Helm Chart is an open source helm chart to install/configure spinnaker.
- Removed "- Spinnaker Operator is an open source Helm chart for installing Spinnaker. " as this is no longer supported by OpsMx
1. Added - [Spinnaker Helm Chart](https://github.com/OpsMx/spinnaker-helm) is an open source helm chart to install/configure spinnaker in GitOps/Non-GitOps style 2. Removed "- [Spinnaker Operator](https://operatorhub.io/operator/spinnaker-operator) is an open source Helm chart for installing Spinnaker. " as this is no longer supported by OpsMx
- [Spinnaker Operator for Kubernetes](https://github.com/armory/spinnaker-operator) is an open source Kubernetes Operator for deploying and managing Spinnaker. You can install a basic version of Spinnaker or use Kustomize files for advanced configuration. | ||
- [Spinnaker Operator](https://operatorhub.io/operator/spinnaker-operator) is an open source Helm chart for installing Spinnaker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context here. Perhaps @rebala can comment? Does anyone know how to remove the operatorhub.io link if this really isn't supported?
It's probably not worth blocking this PR, but, it seems like we'd be better off if the repos we reference here were in github.com/spinnaker. cc: @link108 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbyron-sf the operator link comes from https://github.com/k8s-operatorhub/community-operators/tree/main/operators/opsmx-spinnaker-operator. Need to raise a PR to remove the link from the operatorhub.io.
@keerthibingi please remove the link from the operatorhub for the Spinnaker operator as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebalag removed operator link as per your comments. Here is the PR raised k8s-operatorhub/community-operators#2694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR got merged into https://github.com/k8s-operatorhub/community-operators/tree/main/operators
@dbyron-sf could you please review and approve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still would love to hear from @link108 about repos outside of the spinnaker github org, but generally this LGTM.