Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KalugaFile introduced #638

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

KalugaFile introduced #638

wants to merge 10 commits into from

Conversation

avdyushin
Copy link
Contributor

@thoutbeckers
Copy link
Collaborator

This fails on Android integrations tests:

https://github.com/splendo/kaluga/actions/runs/4045456596/jobs/6959938588#step:8:988

You probably need to add this as a resource path to the android configuration.

@thoutbeckers
Copy link
Collaborator

This does pretty much duplicate a lot of Okio, but I guess with a slightly more simple API. Maybe you want to do your own comparison.

However Okio does nothing with regards to getting the resources in the right place. I see you deal with the resource problem by just copying the resource around to multiple places, this can also be done with gradle configuration.

I suspect you're also lifting along with

afterEvaluate {
to make iOS work, the README would need clear instructions on adding this if that's the case (some of our downstream projects probably do this already)

@avdyushin
Copy link
Contributor Author

This fails on Android integrations tests:

https://github.com/splendo/kaluga/actions/runs/4045456596/jobs/6959938588#step:8:988

You probably need to add this as a resource path to the android configuration.

Yeah, looks like instrumented tests works totally different compare to unit test (and jvm)

@thoutbeckers thoutbeckers self-assigned this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants