-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notice regarding the official singing keys #984
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=========================================
Coverage 75.99% 75.99%
Complexity 3544 3544
=========================================
Files 377 377
Lines 10788 10788
Branches 1374 1374
=========================================
Hits 8198 8198
Misses 2109 2109
Partials 481 481 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have those keys added in a commit signed itself with the key which is somehow (https://keybase.io/ ? personal meeting at some conference?) associated with you @leonard84 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most of the cases it's better to have it documented in that form than not at all. I created #989 to verify them somehow. Please merge as you wish.
This change is