Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERB template option #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ERB template option #8

wants to merge 8 commits into from

Conversation

andyh
Copy link

@andyh andyh commented Feb 27, 2011

Hi,

I've added an option to generate the html files using erb rather than haml for those of us who aren't totally sold on haml if you want to pull this into your repo?

@sporkd
Copy link
Owner

sporkd commented Feb 28, 2011

Awesome! This is cool. I definitely want this.

It's too bad that there's no real good way to specify additional parameters to the compass command. I've considered building a rails generator so that Thor could handle the actual installation. See https://github.com/sporkd/compass-html5-boilerplate/issues#issue/6

My other concern is making people set the ENV['TEMPLATE_ENGINE'] in their running rails app. Unlike the google env variables, if they forget to set this one then things will break. I think it's much better to just have the haml template call ie_tag_haml and the erb template call ie_tag_erb. Then we can just deprecate ie_tag, but leave it in there so older templates don't break.

This also increases the maintenance a bit. But the amount of changes seem to have settled down upstream, so I'm for it.

Thanks again for the effort! Busy week coming up here, but will try to pull it in here asap.

Peter

@andyh
Copy link
Author

andyh commented Feb 28, 2011

Yeah, I think a thor generator would be the best bet - I had assumed compass would be using something like thor anyway so was a bit surprised that you couldn't pass your own options in. I agree about the ENV var though, it felt a bit hacky to have it in rails too.

@iconoclast
Copy link

If anyone's interested, I took andy's work and added a fallback so it will use erb when haml isn't installed. This way you don't have to worry about the ENV vary unless you're mixing erb and haml in the same site for some reason.
https://github.com/iconoclast/compass-html5-boilerplate

@ntreadway
Copy link

Just what I was looking for thx iconoclast.

@alup
Copy link

alup commented Jul 2, 2011

When will it be merged to the master branch? This feature is important for lots of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants