Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: react-native runtime incompatibilities #202

Merged
merged 6 commits into from
Oct 3, 2024
Merged

fix: react-native runtime incompatibilities #202

merged 6 commits into from
Oct 3, 2024

Conversation

andreas-karlsson
Copy link
Contributor

This PR fixes two react-native compatibility issues with the iOS runtime:

  • AbortSignal.throwIfAborted is not supported
  • It's more picky with creating new Requests. More specifically, even if overriding the body of a request, you can't use an already consumed request as the template.

✔️ Checklist

  • All tests are passing
  • Relevant documentation updated
  • linter/style run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes
  • Tested in a corresponding example app

nicklasl
nicklasl previously approved these changes Oct 3, 2024
View reviewed changes
@nicklasl nicklasl merged commit f594e77 into main Oct 3, 2024
2 checks passed
@nicklasl nicklasl deleted the react-native-fixes branch October 3, 2024 14:16
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl approved these changes

@Billlynch Billlynch Awaiting requested review from Billlynch Billlynch is a code owner

@fabriziodemaria fabriziodemaria Awaiting requested review from fabriziodemaria fabriziodemaria is a code owner

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-karlsson @nicklasl