-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch datum factory for specific data in IOs #4975
Conversation
DatumReader<ValueT> datumReader = | ||
recordClass == null | ||
? new GenericDatumReader<>(schema) | ||
: new ReflectDatumReader<>(recordClass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SMB avro read was not symmetric with writer and did not have any logical type conversion applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were lucky nobody used logical types in SMB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it yes
Codecov Report
@@ Coverage Diff @@
## main #4975 +/- ##
==========================================
+ Coverage 63.09% 63.12% +0.02%
==========================================
Files 282 283 +1
Lines 10649 10659 +10
Branches 767 765 -2
==========================================
+ Hits 6719 6728 +9
- Misses 3930 3931 +1
|
7ba9cca
to
5cc77ba
Compare
Quick patch for apache/beam#28279
Unfortunately, contains some code duplication: