spring-cloud-security issue #61 #1523
Conversation
|
@andye2004 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@andye2004 Thank you for signing the Contributor License Agreement! |
|
spring-attic/spring-cloud-security#61 seems still relevant, so does this PR. |
There has been no feedback from the spring guys at all. I think they are all concentrating on other things. I agree though, this is still relevant but maybe it should be ported to a more up-to-date branch/version. |
|
Closing as this is a major change that we are no longer accepting. As you may be aware, this project is in maintenance mode and will reach EOL in the very near future. Please see the initial announcement and follow-up announcement for further details. At this time, we are only accepting bug fixes and minor enhancements that can be cleanly merged into master. Thank you for your understanding and we would welcome your contributions to the new OAuth 2.0 / OpenID Connect support in Spring Security. |
jgrandja
added
in: oauth2
status: declined
and removed
status: waiting-for-triage
labels
The issue this PR relates to is recorded in Spring Cloud Security project but the required changes are obviously in Spring Security OAuth2. I made a comment on that discussion that I felt the change to support browser redirects should not be pulling in a discovery service and that instead the change should simply provide a mechanism where people can provide their own mechanism for doing so.
This PR doesn't modify the existing behaviour in any way but adds the ability to introduce service aware resolvers that can be used to resolve a service name based URI into an absolute URI that can be used with browsers.