Moved the code from Spring Cloud Security #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
============================================
- Coverage 78.44% 77.91% -0.53%
- Complexity 407 417 +10
============================================
Files 48 49 +1
Lines 1452 1499 +47
Branches 215 222 +7
============================================
+ Hits 1139 1168 +29
- Misses 212 227 +15
- Partials 101 104 +3
|
spencergibb
approved these changes
Dec 15, 2020
| @@ -119,6 +119,11 @@ | |||
| <artifactId>okhttp</artifactId> | |||
| <optional>true</optional> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.springframework.security.oauth.boot</groupId> | |||
| <artifactId>spring-security-oauth2-autoconfigure</artifactId> | |||
There was a problem hiding this comment.
Was hoping to move to the new stuff, but just having this moved is better. I think there's an open issue, that can come in a SR
There was a problem hiding this comment.
this one that should be moved to this project probably spring-attic/spring-cloud-security#173
in the comments there are links to a couple of possible implementation using Spring Security only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe @dsyer or @spencergibb will remember why there was no auto configuration for the oauth2 interceptor for Feign in the first place? I couldn't find one in Spring Cloud Security.
fixes #444