Fix time cut-off on time_ns #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbabics
force-pushed
the
fix/time-ns-precision
branch
from
087e1c6
to
c370104
Compare
| @@ -180,7 +180,8 @@ def fake_time(): | |||
| def fake_time_ns(): | |||
| if _should_use_real_time(): | |||
| return real_time_ns() | |||
| return int(int(fake_time()) * 1e9) | |||
| current_time = get_current_time() | |||
| return int(calendar.timegm(current_time.timetuple()) * 1_000_000_000 + current_time.microsecond * 1_000) | |||
|
|
|||
There was a problem hiding this comment.
Why not return int(fake_time() * 1e9)?
There was a problem hiding this comment.
Oh, I see – fake_time() * 1e9 could cause problems with precision and this integer multiplication won't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
currently
time.time_nsis being updated to time cut to seconds, which is kind of weird behavior in regards totime.timewhich returns the decimal part.Basically this should (hopefully) fix the issue with:
time.time_ns() / 1e9 != time.time()