-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Check for asset availability when checking for update #22598
base: master
Are you sure you want to change the base?
Conversation
f53e4ad
to
78fef01
Compare
379eced
to
b2da67c
Compare
68153cd
to
a0ec21a
Compare
b558ba3
to
6552f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review for you @mrclary.
Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-15 03:31:53 UTC |
@ccordoba12, thank you for suggesting the |
…o an available update. Create a function that determines the asset name, update type, and url, depending on the latest release and the current Spyder version. Fixes spyder-ide#22566
…WorkerDownloadInstaller.latest_release are now packaging.version.Version objects instead of strings. We can now use packaging.version mechanisms for comparison, sorting, and stable release checks.
Added test_update_no_asset and test_get_asset_info
Co-authored-by: Carlos Cordoba <[email protected]>
dde2b0c
to
bfdca46
Compare
Description of Changes
UpdateWorker.channel
is assigned.Issue(s) Resolved
Fixes #22566
Fixes #22572