PR: Check for asset availability when checking for update #22598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclary
changed the title
mrclary
force-pushed
the
update-manager
branch
from
f53e4ad
to
78fef01
Compare
mrclary
force-pushed
the
update-manager
branch
2 times, most recently
from
379eced
to
b2da67c
Compare
mrclary
force-pushed
the
update-manager
branch
3 times, most recently
from
68153cd
to
a0ec21a
Compare
mrclary
force-pushed
the
update-manager
branch
2 times, most recently
from
b558ba3
to
6552f65
Compare
ccordoba12
reviewed
Oct 14, 2024
|
Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-15 03:31:53 UTC |
@ccordoba12, thank you for suggesting the |
…o an available update. Create a function that determines the asset name, update type, and url, depending on the latest release and the current Spyder version. Fixes spyder-ide#22566
…WorkerDownloadInstaller.latest_release are now packaging.version.Version objects instead of strings. We can now use packaging.version mechanisms for comparison, sorting, and stable release checks.
Added test_update_no_asset and test_get_asset_info
Co-authored-by: Carlos Cordoba <[email protected]>
mrclary
force-pushed
the
update-manager
branch
from
dde2b0c
to
bfdca46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
UpdateWorker.channelis assigned.Issue(s) Resolved
Fixes #22566
Fixes #22572