-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first possible annotation syntax #24
Open
ucyo
wants to merge
11
commits into
main
Choose a base branch
from
annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4fa4eb1
Add first possible annotation syntax
ucyo 58f615c
Cleanup
ucyo 966be51
Add scaffolding for code
ucyo 0935866
Export function for json included
ucyo 5148e6a
Reverse former edit
ucyo 78587cf
Add annotations to cleanup process
ucyo b069342
Refer to annotations externally
ucyo 1d3afba
Fix json output
ucyo 7b05600
No cleanup
ucyo e634db0
Add a python script to add annotations to hyperfine result file
ucyo 7886772
Update Python script
ucyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import sys | ||
import subprocess as sp | ||
import json | ||
from dataclasses import dataclass, field | ||
|
||
""" Piped commands not working currently | ||
""" | ||
|
||
@dataclass | ||
class Annotation: | ||
json: str | ||
data: dict = field(init=False) | ||
|
||
def __post_init__(self): | ||
with open(self.json, 'r') as f: | ||
self.data = json.load(f) | ||
|
||
def execute_cmd(self, key, cmd): | ||
try: | ||
result = sp.check_output(cmd, shell=True).decode('ascii') | ||
except sp.CalledProcessError as err: | ||
print(f"Failed w/ {err}") | ||
raise | ||
else: | ||
tmp = self.data["results"][0] | ||
if hasattr(tmp,"annotations"): | ||
tmp["annotations"][key] = result | ||
else: | ||
tmp["annotations"] = {key:result} | ||
self.data["results"][0] = tmp | ||
|
||
def export(self): | ||
with open('new_' + self.json, 'w') as f: | ||
json.dump(self.data, f, indent=2) | ||
|
||
|
||
def main(keyword, hyperfine_json, cmd): | ||
annon = Annotation(hyperfine_json) | ||
annon.execute_cmd(keyword, cmd) | ||
annon.export() | ||
|
||
if __name__ == '__main__': | ||
keyword = sys.argv[1] | ||
js = sys.argv[2] | ||
command = sys.argv[3:] | ||
main(keyword = keyword, hyperfine_json = js, cmd = command) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This override of the file is not working with jq .. the output will be empty