Fix #121; respect truthiness of filterFunction.

square · Aug 5, 2014 · 6103b76 · 6103b76
1 parent 8aad3a4
commit 6103b76
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/crossfilter.js b/crossfilter.js
@@ -1,5 +1,5 @@
 (function(exports){
-crossfilter.version = "1.3.7";
+crossfilter.version = "1.3.8";
 function crossfilter_identity(d) {
   return d;
 }
@@ -825,7 +825,7 @@ function crossfilter() {
           removed = [];
 
       for (i = 0; i < n; ++i) {
-        if (!(filters[k = index[i]] & one) ^ (x = f(values[i], i))) {
+        if (filters[k = index[i]] & one ^ !(x = f(values[i], i))) {
           if (x) filters[k] &= zero, added.push(k);
           else filters[k] |= one, removed.push(k);
         }

diff --git a/crossfilter.min.js b/crossfilter.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "crossfilter",
-  "version": "1.3.7",
+  "version": "1.3.8",
   "description": "Fast multidimensional filtering for coordinated views.",
   "keywords": [
     "square",

diff --git a/src/crossfilter.js b/src/crossfilter.js
@@ -297,7 +297,7 @@ function crossfilter() {
           removed = [];
 
       for (i = 0; i < n; ++i) {
-        if (!(filters[k = index[i]] & one) ^ (x = f(values[i], i))) {
+        if (filters[k = index[i]] & one ^ !(x = f(values[i], i))) {
           if (x) filters[k] &= zero, added.push(k);
           else filters[k] |= one, removed.push(k);
         }