Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Fix handling of spaces in squeak.sh args #29

Merged

Conversation

LinqLover
Copy link
Contributor

Do not split up command line arguments with spaces by using a bash array instead of concatenated string.

Fixes #28. Still, proper tests are missing - better send me a few other scenarios before merging this patch, or try them out yourself. See also #27.

Do not split up command line arguments with spaces by using a bash array instead of concatenated string.

Fixes squeak-smalltalk#28. Still, proper tests are missing - better send me a few other scenarios before merging this patch, or try them out yourself. See also squeak-smalltalk#27.
@marceltaeumel
Copy link
Member

Hmm... http://mywiki.wooledge.org/BashFAQ/050

Yet, I think that we do need support for spaces in that argument for --doit ...

@marceltaeumel marceltaeumel merged commit 614c538 into squeak-smalltalk:squeak-trunk Apr 28, 2022
@LinqLover
Copy link
Contributor Author

I also found shellcheck and its docs very helpful: https://github.com/koalaman/shellcheck/wiki/SC2086

(There is even a VS Code extension for it, in case you didn't know already :D)

@LinqLover LinqLover deleted the fix-squeak.sh-stargs branch April 28, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

squeak.sh cannot pass arguments with spaces to the image
2 participants