Huge Refactor/Renovation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done out of a frustration of where the code-base was and how hard it was to make the needed changes to add rev2 support for things like the bootloader and such. This was due to some very bad decisions that were made early on in a "just hack it together" mindset early on to get something working, but the problems from that proliferated around and made it very *very* painful to actually make the needed changes now. As such, we basically took a hack-saw to the code and tried to improve everything we could see that was wrong and hampering us. As a result of this we also improved the internal documentation a bit, and also fixed some sneaky bugs we found, as well as improving the design of some things such as the cache system.
lethalbit
force-pushed
the
aki/renovation
branch
from
c561472
to
33d8385
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
dragonmux
added
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done out of a frustration of where the code-base was and how hard it was to
make the needed changes to add rev2 support for things like the bootloader and such.
This was due to some very bad decisions that were made early on in a "just hack it together"
mindset early on to get something working, but the problems from that proliferated around
and made it very very painful to actually make the needed changes now.
As such, we basically took a hack-saw to the code and tried to improve everything we could see
that was wrong and hampering us. As a result of this we also improved the internal documentation
a bit, and also fixed some sneaky bugs we found, as well as improving the design of some things
such as the cache system.