Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #15

wants to merge 1 commit into from

Conversation

DavidLRowe
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@srl295
Copy link
Owner

srl295 commented Oct 18, 2023

@DavidLRowe you're the assignee!

@DavidLRowe
Copy link
Author

But I don't have write access to the repo.

@srl295
Copy link
Owner

srl295 commented Oct 18, 2023

yes, but GitHub allows an author or commenter to be assigned. I could have assigned you manually.

@DavidLRowe
Copy link
Author

So this assigns the PR to me on GitHub. In the TC discussion today, I had assumed we were talking about the assignee on the CLDR ticket. Are they necessarily the same? That could be a point of confusion (I certainly was!) and should be made explicit in the discussion.

@srl295
Copy link
Owner

srl295 commented Oct 18, 2023

So this assigns the PR to me on GitHub. In the TC discussion today, I had assumed we were talking about the assignee on the CLDR ticket. Are they necessarily the same? That could be a point of confusion (I certainly was!) and should be made explicit in the discussion.

No, we were talking about the PR assignee, those are definitely different.

@DavidLRowe
Copy link
Author

Yes, I see that now. I'm just suggesting that you consider including a sentence like "(This is the PR assignee, not the CLDR ticket assignee.)"

@srl295
Copy link
Owner

srl295 commented Oct 18, 2023

Yes, I see that now. I'm just suggesting that you consider including a sentence like "(This is the PR assignee, not the CLDR ticket assignee.)"

I added that to the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants