Make our upstream proxies configurable #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as NGINX will refuse to start if the upstream services cannot be resolved.
This is required as NGINX will refuse to start if the upstream services cannot be resolved.
2 tasks
RealOrangeOne
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is required as NGINX will refuse to start if the upstream services cannot be resolved.
Currently the SRComp proxy is not around, meaning that nginx is in a fragile state. It's had the offending lines manually commented out; this PR makes the relevant parts of the config configurable and sets the values we currently want.
Code review
Testing
Links
Alternative approach to #51, though they could be combined.