RFC: Add search #454
Draft
RFC: Add search #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
reviewed
Apr 11, 2023
Comment on lines
7
to
10
| "dependencies": { | ||
| "cspell": "5.18.5" | ||
| "cspell": "5.18.5", | ||
| "pagefind": "^0.12.0" | ||
| } |
There was a problem hiding this comment.
If we're moving to actually building JS stuff here we should move cspell into devDependencies.
PeterJCLaw
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Is there a missing call to npm build-search-index in this file?
|
Is this related to the experimentation that was previously being done with Algolia? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a site search for finding some things more easily. It's not perfect, but it's something.
Update: I realised,whilst writing this that this won't actually work, as we're still relying on GitHub Pages automatically deploying our site. If we move to manually deploying the site ourselves, it will then work. Until we have that, this is here for review.