add mountPoints to Service
#1240
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvictor
commented
Oct 10, 2024
zvictor
commented
Oct 10, 2024
Comment on lines
+982
to
+1006
| /** | ||
| * The mount points for the data volumes in your container. | ||
| * This parameter maps to Volumes in the creat-container Docker API and the `--volume` | ||
| * option to docker run. | ||
| * | ||
| * Windows containers can mount whole directories on the same drive as `$env:ProgramData`. | ||
| * Windows containers cannot mount directories on a different drive, and mount points | ||
| * cannot be used across drives. You must specify mount points to attach an Amazon EBS | ||
| * volume directly to an Amazon ECS task. | ||
| */ | ||
| mountPoints?: { | ||
| /** | ||
| * The name of the volume to mount. | ||
| */ | ||
| sourceVolume: Input<string>; | ||
|
|
||
| /** | ||
| * The path in the container where the volume will be mounted. | ||
| */ | ||
| containerPath: Input<string>; | ||
| /** | ||
| * If this value is true, the container has read-only access to the volume. If this value is false, then the container can write to the volume. The default value is false. | ||
| */ | ||
| readOnly?: Input<boolean>; | ||
| }[]; |
There was a problem hiding this comment.
should I copy this block to top-level ServiceArgs?
|
I see your other PR as well. Maybe we should reopen your old issue and link these there. |
|
Amazing! Any chance this might get merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to Containers'
mountPointsis needed in order to attach volumes/filesystems.This is part of #434 and this.