Add review comments #16180
MatheusFranco99Annotations
10 errors and 2 warnings
|
lint:
protocol/v2/ssv/testing/runner.go#L87
cannot use identifier.GetRoleType() (value of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to testing.TestingConfig (typecheck)
|
|
lint:
protocol/v2/ssv/testing/runner.go#L291
cannot use identifier.GetRoleType() (value of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to testing.TestingConfig (typecheck)
|
|
lint:
cli/operator/node.go#L38
could not import github.com/ssvlabs/ssv/message/validation (-: # github.com/ssvlabs/ssv/message/validation
|
|
lint:
message/validation/partial_validation.go#L109
undefined: PartialSignatureSize
|
|
lint:
message/validation/partial_validation.go#L110
undefined: ErrWrongBLSSignatureSize) (typecheck)
|
|
lint:
ibft/storage/stores_test.go#L22
cannot use spectypes.RoleCommittee (constant 0 of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to qbftMap.Add
|
|
lint:
ibft/storage/stores_test.go#L23
cannot use spectypes.RoleCommittee (constant 0 of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to qbftMap.Add
|
|
lint:
ibft/storage/stores_test.go#L25
cannot use spectypes.RoleCommittee (constant 0 of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to qbftMap.Get
|
|
lint:
ibft/storage/stores_test.go#L26
cannot use spectypes.RoleCommittee (constant 0 of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to qbftMap.Get
|
|
lint:
ibft/storage/stores_test.go#L32
cannot use spectypes.RoleCommittee (constant 0 of type "github.com/ssvlabs/ssv-spec/types".RunnerRole) as convert.RunnerRole value in argument to NewStoresFromRoles
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|