network/discovery: replace skipped peers log with metric

ssvlabs · Oct 18, 2024 · 8e0a9e5 · 8e0a9e5
1 parent 3de919b
commit 8e0a9e5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/network/discovery/dv5_service.go b/network/discovery/dv5_service.go
@@ -138,13 +138,8 @@ func (dvs *DiscV5Service) Bootstrap(logger *zap.Logger, handler HandleNewPeer) e
 	logger = logger.Named(logging.NameDiscoveryService)
 
 	dvs.discover(dvs.ctx, func(e PeerEvent) {
-		logger := logger.With(
-			fields.ENR(e.Node),
-			fields.PeerID(e.AddrInfo.ID),
-		)
-		err := dvs.checkPeer(logger, e)
-		if err != nil {
-			logger.Debug("skipped discovered peer", zap.Error(err))
+		if err := dvs.checkPeer(logger, e); err != nil {
+			metricSkippedPeers.WithLabelValues(e.Node.String(), e.AddrInfo.ID.String(), err.Error()).Inc()
 			return
 		}
 		handler(e)

diff --git a/network/discovery/metrics.go b/network/discovery/metrics.go
@@ -27,6 +27,10 @@ var (
 		Name: "ssv:network:discovery:iterations",
 		Help: "Counts the number of times a node was iterated using the mixed iterator",
 	}, []string{"fork"})
+	metricSkippedPeers = promauto.NewCounterVec(prometheus.CounterOpts{
+		Name: "ssv:network:discovery:skipped_peers",
+		Help: "Counts skipped peers",
+	}, []string{"enr", "peer_id", "err"})
 )
 
 func init() {
@@ -46,4 +50,7 @@ func init() {
 	if err := prometheus.Register(metricIterations); err != nil {
 		logger.Debug("could not register prometheus collector")
 	}
+	if err := prometheus.Register(metricSkippedPeers); err != nil {
+		logger.Debug("could not register prometheus collector")
+	}
 }