tests: executionclient fix & simplify #1781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurii-ssv
commented
Oct 9, 2024
Comment on lines
-192
to
197
| Unfollowed: | ||
| Wait1: | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| require.Equal(t, int64(blocksWithLogsLength-followDistance), streamedLogsCount.Load()) | ||
| require.Failf(t, "timed out", "err: %v, streamedLogsCount: %d", ctx.Err(), streamedLogsCount.Load()) | ||
| case <-time.After(time.Millisecond * 5): | ||
| if streamedLogsCount.Load() == int64(blocksWithLogsLength-followDistance) { | ||
| break Unfollowed | ||
| break Wait1 | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
So, (on stage version) if we drop into case <-ctx.Done() branch here this for loop will very likely spin perpetually (allocating new Timer on every iteration through time.After).
nkryuchkov
approved these changes
Oct 9, 2024
Comment on lines
-192
to
197
| Unfollowed: | ||
| Wait1: | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| require.Equal(t, int64(blocksWithLogsLength-followDistance), streamedLogsCount.Load()) | ||
| require.Failf(t, "timed out", "err: %v, streamedLogsCount: %d", ctx.Err(), streamedLogsCount.Load()) | ||
| case <-time.After(time.Millisecond * 5): | ||
| if streamedLogsCount.Load() == int64(blocksWithLogsLength-followDistance) { | ||
| break Unfollowed | ||
| break Wait1 | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves potential memory leak (similar to what's described in #1780), also simplifying the test affected.