Concurrent slashing protection tests #1809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurii-ssv
reviewed
Oct 22, 2024
Comment on lines
+852
to
+856
| if err != nil && err.Error() == "slashable attestation (HighestAttestationVote), not signing" { | ||
| slashableErrors++ | ||
| } else if err == nil { | ||
| successCount++ | ||
| } |
There was a problem hiding this comment.
Shouldn't we check here for the absence of errors other than "slashable attestation (HighestAttestationVote), not signing" (or leave a comment explaining why not) ? Same for another test.
Edit: I guess the require checks below implicitly do this, but it's way easier to understand/debug when "failing fast" (and explicitly).
Comment on lines
+890
to
+891
| // Set up concurrency. | ||
| const goroutineCount = 100 |
There was a problem hiding this comment.
Can probably set to 1000 (or even 10000) to get the most out of this test. Same for another test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1672