Base vaults and strategies upgrade & QSMF #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds, change forking block, fixes
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 90.75% 93.69% +2.94%
==========================================
Files 49 50 +1
Lines 3730 3697 -33
Branches 433 426 -7
==========================================
+ Hits 3385 3464 +79
+ Misses 205 97 -108
+ Partials 140 136 -4 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+35
to
+37
| if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyId)) { | ||
| ++total; | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
Comment on lines
+48
to
+52
| if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyId)) { | ||
| nums[total] = i; | ||
| variants[total] = generateDescription(farm, _ammAdapter); | ||
| ++total; | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
a17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.