-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRMF #103
GRMF #103
Conversation
if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyLogicId())) { | ||
++localTtotal; | ||
} |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
There are more advantages, such as easier to read code and better coverage reports.
if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyLogicId())) { | ||
nums[localTtotal] = i; | ||
//slither-disable-next-line calls-loop | ||
variants[localTtotal] = _generateDescription(farm, _ammAdapter); | ||
++localTtotal; | ||
} |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
There are more advantages, such as easier to read code and better coverage reports.
if (amountsToDeposit[0] > 1 && amountsToDeposit[1] > 1) { | ||
uint valueToReceive; | ||
(amountsToDeposit, valueToReceive) = _previewDepositAssets(amountsToDeposit); | ||
if (valueToReceive > 10) { | ||
_depositAssets(amountsToDeposit, false); | ||
} | ||
} |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-nested-if Note
There are more advantages, such as easier to read code and better coverage reports.
function extra() external pure returns (bytes32) { | ||
return CommonLib.bytesToBytes32(abi.encodePacked(bytes3(0xff0000), bytes3(0x000000))); | ||
} |
Check warning
Code scanning / Slither
Too many digits Warning
- CommonLib.bytesToBytes32(abi.encodePacked(bytes3(0xff0000),bytes3(0x000000)))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 93.69% 93.79% +0.09%
==========================================
Files 50 51 +1
Lines 3697 3837 +140
Branches 426 437 +11
==========================================
+ Hits 3464 3599 +135
Misses 97 97
- Partials 136 141 +5 ☔ View full report in Codecov by Sentry. |
No description provided.