Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRMF #103

Merged
merged 1 commit into from
Mar 6, 2024
Merged

GRMF #103

merged 1 commit into from
Mar 6, 2024

Conversation

a17
Copy link
Member

@a17 a17 commented Mar 6, 2024

No description provided.

@a17 a17 linked an issue Mar 6, 2024 that may be closed by this pull request
Comment on lines +131 to +133
if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyLogicId())) {
++localTtotal;
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
Comment on lines +144 to +149
if (farm.status == 0 && CommonLib.eq(farm.strategyLogicId, strategyLogicId())) {
nums[localTtotal] = i;
//slither-disable-next-line calls-loop
variants[localTtotal] = _generateDescription(farm, _ammAdapter);
++localTtotal;
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
Comment on lines +275 to +281
if (amountsToDeposit[0] > 1 && amountsToDeposit[1] > 1) {
uint valueToReceive;
(amountsToDeposit, valueToReceive) = _previewDepositAssets(amountsToDeposit);
if (valueToReceive > 10) {
_depositAssets(amountsToDeposit, false);
}
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
Comment on lines +166 to +168
function extra() external pure returns (bytes32) {
return CommonLib.bytesToBytes32(abi.encodePacked(bytes3(0xff0000), bytes3(0x000000)));
}

Check warning

Code scanning / Slither

Too many digits Warning

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.79%. Comparing base (5a22ba1) to head (7643f64).

Files Patch % Lines
src/strategies/GammaRetroMerklFarmStrategy.sol 96.37% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   93.69%   93.79%   +0.09%     
==========================================
  Files          50       51       +1     
  Lines        3697     3837     +140     
  Branches      426      437      +11     
==========================================
+ Hits         3464     3599     +135     
  Misses         97       97              
- Partials      136      141       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a17 a17 merged commit 0fdb054 into main Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DONE] Gamma Retro Merkl Farm
1 participant