Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.05.0-alpha; ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0 #116

Merged
merged 20 commits into from
May 4, 2024

Conversation

a17
Copy link
Member

@a17 a17 commented Apr 29, 2024

YearnStrategy

  • integration interfaces
  • constants
  • skeleton
  • universal test
  • implementation
  • deploy script

ERC4626StrategyBase

  • skeleton
  • storage
  • getRevenue
  • _depositAssets
  • _withdrawAssets
  • _claimRevenue

VaultBase 1.3.0

  • hardWorkMintFeeCallback(address[] memory revenueAssets, uint[] memory revenueAmounts)

StrategyBase 1.1.0

  • autoCompoundingByUnderlyingProtocol()
  • virtual total()

Factory 1.1.0

  • getDeploymentKey() fix for not farming strategies
  • strategyAvailableInitParams(bytes32 idHash) another strategy init params store, for not farming and complex strategies

@a17 a17 added enhancement New feature or request STRATEGY Strategy logic proposed for implementation BASE STRATEGY Base strategy implementation related tasks labels Apr 29, 2024
@a17 a17 self-assigned this Apr 29, 2024
src/strategies/base/StrategyBase.sol Fixed Show fixed Hide fixed
src/strategies/base/ERC4626StrategyBase.sol Fixed Show fixed Hide fixed
src/strategies/base/ERC4626StrategyBase.sol Fixed Show fixed Hide fixed
src/strategies/base/ERC4626StrategyBase.sol Fixed Show fixed Hide fixed
src/strategies/YearnStrategy.sol Fixed Show fixed Hide fixed
This was linked to issues Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 96.93252% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 94.21%. Comparing base (34868d0) to head (481dc8f).

Files Patch % Lines
src/core/libs/VaultBaseLib.sol 94.28% 0 Missing and 2 partials ⚠️
src/core/base/VaultBase.sol 83.33% 0 Missing and 1 partial ⚠️
src/strategies/base/ERC4626StrategyBase.sol 98.43% 0 Missing and 1 partial ⚠️
src/strategies/base/StrategyBase.sol 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   93.92%   94.21%   +0.28%     
==========================================
  Files          54       57       +3     
  Lines        4148     4304     +156     
  Branches      462      476      +14     
==========================================
+ Hits         3896     4055     +159     
+ Misses        101       94       -7     
- Partials      151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a17 a17 added the PLATFORM UPGRADE Upgrading platform core contracts with the described changes label Apr 29, 2024
@a17 a17 changed the title ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0 ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0, Factory 1.1.0 Apr 29, 2024
@a17 a17 changed the title ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0, Factory 1.1.0 24.05.0-alpha; ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0 Apr 29, 2024
src/core/libs/VaultBaseLib.sol Fixed Show fixed Hide fixed
src/core/libs/VaultBaseLib.sol Fixed Show fixed Hide fixed
src/core/libs/VaultBaseLib.sol Fixed Show fixed Hide fixed
src/strategies/base/ERC4626StrategyBase.sol Dismissed Show dismissed Hide dismissed
src/strategies/YearnStrategy.sol Fixed Show fixed Hide fixed
src/strategies/YearnStrategy.sol Fixed Show fixed Hide fixed
src/strategies/YearnStrategy.sol Fixed Show fixed Hide fixed
@a17 a17 requested a review from 0xhokugava May 4, 2024 16:28
@a17 a17 marked this pull request as ready for review May 4, 2024 16:30
@0xhokugava 0xhokugava merged commit 17a6420 into main May 4, 2024
8 checks passed
@a17 a17 mentioned this pull request May 7, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BASE STRATEGY Base strategy implementation related tasks enhancement New feature or request PLATFORM UPGRADE Upgrading platform core contracts with the described changes STRATEGY Strategy logic proposed for implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC4626StrategyBase [DONE] Yearn
2 participants