-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.05.0-alpha; ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a17
added
enhancement
New feature or request
STRATEGY
Strategy logic proposed for implementation
BASE STRATEGY
Base strategy implementation related tasks
labels
Apr 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 93.92% 94.21% +0.28%
==========================================
Files 54 57 +3
Lines 4148 4304 +156
Branches 462 476 +14
==========================================
+ Hits 3896 4055 +159
+ Misses 101 94 -7
- Partials 151 155 +4 ☔ View full report in Codecov by Sentry. |
a17
added
the
PLATFORM UPGRADE
Upgrading platform core contracts with the described changes
label
Apr 29, 2024
a17
changed the title
ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0
ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0, Factory 1.1.0
Apr 29, 2024
a17
changed the title
ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0, Factory 1.1.0
24.05.0-alpha; ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0
Apr 29, 2024
0xhokugava
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BASE STRATEGY
Base strategy implementation related tasks
enhancement
New feature or request
PLATFORM UPGRADE
Upgrading platform core contracts with the described changes
STRATEGY
Strategy logic proposed for implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YearnStrategy
ERC4626StrategyBase
VaultBase 1.3.0
hardWorkMintFeeCallback(address[] memory revenueAssets, uint[] memory revenueAmounts)
StrategyBase 1.1.0
autoCompoundingByUnderlyingProtocol()
total()
Factory 1.1.0
getDeploymentKey()
fix for not farming strategiesstrategyAvailableInitParams(bytes32 idHash)
another strategy init params store, for not farming and complex strategies