Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gyroscope AMM adapter & Gyroscope Aura Farm #141

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'main' into 123-gyroscope-amm-adapter

bec0ce4
Select commit
Loading
Failed to load commit list.
Draft

Gyroscope AMM adapter & Gyroscope Aura Farm #141

Merge branch 'main' into 123-gyroscope-amm-adapter
bec0ce4
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS succeeded Jul 16, 2024 in 5s

25 new alerts

New alerts in code changed by this pull request

  • 25 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 134 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 277 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 281 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 466 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 466 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 496 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 503 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 558 in src/adapters/libs/GyroECLPMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 43 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.

Check notice on line 43 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 71 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.

Check notice on line 71 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 153 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note

Consider using custom errors as they are more gas efficient while allowing developers
to describe the error in detail using NatSpec.

Check notice on line 153 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-multiple-require Note

Using multiple require statements is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 305 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.

Check notice on line 305 in src/adapters/libs/GyroPoolMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-prefix-increment-not-postfix Note

Consider using the prefix increment expression whenever the return value is not needed.
The prefix increment expression is cheaper in terms of gas.

Check notice on line 45 in src/adapters/libs/balancer-labs-v2-solidity-utils/helpers/InputHelpers.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.

Check notice on line 129 in src/adapters/libs/balancer-labs-v2-solidity-utils/math/LogExpMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 296 in src/adapters/libs/balancer-labs-v2-solidity-utils/math/LogExpMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 303 in src/adapters/libs/balancer-labs-v2-solidity-utils/math/LogExpMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 319 in src/adapters/libs/balancer-labs-v2-solidity-utils/math/LogExpMath.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 76 in src/adapters/GyroscopeAdapter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note

Consider using custom errors as they are more gas efficient while allowing developers
to describe the error in detail using NatSpec.

Check notice on line 88 in src/adapters/GyroscopeAdapter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note

Consider using custom errors as they are more gas efficient while allowing developers
to describe the error in detail using NatSpec.

Check notice on line 86 in src/adapters/GyroscopeAdapter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 107 in src/adapters/GyroscopeAdapter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note

Caching the array length outside a loop saves reading it on each iteration, as long as the array's length is not changed during the loop.