Builder #157
Open
Builder #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
a17
added
the
PLATFORM UPGRADE
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+69
to
+103
| function invest(address asset, uint amount) external nonReentrant returns (uint48 amountUSD) { | ||
| IPriceReader priceReader = IPriceReader(IPlatform(platform()).priceReader()); | ||
| (uint price, bool trusted) = priceReader.getPrice(asset); | ||
| if (!trusted) { | ||
| revert NotTrustedPriceFor(asset); | ||
| } | ||
| amountUSD = uint48(amount * price / 10 ** IERC20Metadata(asset).decimals() * USD_DENOMINATOR / 1e18); | ||
| if (amountUSD == 0) { | ||
| revert ZeroAmountToInvest(); | ||
| } | ||
|
|
||
| BuilderStorage storage $ = _getStorage(); | ||
| uint tokenId = $.ownedToken[msg.sender]; | ||
|
|
||
| if (tokenId == 0) { | ||
| if (amountUSD < MIN_AMOUNT_FOR_MINTING) { | ||
| revert TooLittleAmountToInvest(amountUSD, MIN_AMOUNT_FOR_MINTING); | ||
| } | ||
| tokenId = $.newTokenId; | ||
| $.newTokenId = tokenId + 1; | ||
| $.ownedToken[msg.sender] = tokenId; | ||
| _mint(msg.sender, tokenId); | ||
| } else { | ||
| if (amountUSD < MIN_AMOUNT_FOR_ADDING) { | ||
| revert TooLittleAmountToInvest(amountUSD, MIN_AMOUNT_FOR_ADDING); | ||
| } | ||
| } | ||
|
|
||
| TokenData storage tokenData = $.tokenData[tokenId]; | ||
| tokenData.invested += amountUSD; | ||
|
|
||
| IERC20(asset).safeTransferFrom(msg.sender, address(this), amount); | ||
|
|
||
| emit Invested(msg.sender, tokenId, asset, amount, amountUSD); | ||
| } |
Check warning
Code scanning / Slither
Divide before multiply Medium
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 94.76% 98.00% +3.24%
==========================================
Files 60 61 +1
Lines 4428 4456 +28
Branches 477 481 +4
==========================================
+ Hits 4196 4367 +171
- Misses 77 82 +5
+ Partials 155 7 -148 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.