Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds render cross reference in links #6

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Adds render cross reference in links #6

merged 2 commits into from
Jun 13, 2024

Conversation

emmanuelmathot
Copy link
Member

This PR Adds render cross reference in links and fix #2

This PR Adds render cross reference in links and fix #2
@@ -34,6 +34,37 @@
}
}
}
},
{
"if": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this schema saying if stac extensions includes both renders and web-map-links, a render sub-property is required? Why do you think it should be required? Seems like an optional property.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I may be mis-reading the schema but does the then statement mean that there must be a link object in the links list that has "rel": "render" - in which case does the example above needs updating to include a link with "rel": "render"?

@abarciauskas-bgse
Copy link
Collaborator

@emmanuelmathot this makes sense to me but I wonder if this spec should be in the web-map-links extension rather than here, since the change is in the links object, not the renders object.

@emmanuelmathot
Copy link
Member Author

@emmanuelmathot this makes sense to me but I wonder if this spec should be in the web-map-links extension rather than here, since the change is in the links object, not the renders object.

The change specifies an extension to link but specific to render so this should be set here. If the logic discussed here: radiantearth/stac-spec#1284 similar to this proposition changes, we will adapt to the logic but for the moment, we will add the possibility to link a render in a link.

@emmanuelmathot emmanuelmathot merged commit 2ae1874 into main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to map a render service
2 participants