Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EDC Connector #373

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Added EDC Connector #373

wants to merge 11 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented May 22, 2023

The image builds and works for me.

@fhennig fhennig marked this pull request as ready for review May 22, 2023 13:40
@fhennig
Copy link
Contributor Author

fhennig commented Jun 5, 2023

note: as of today we do not want to merge this.

The image is built though, it's in the 'sandbox'

Don't delete the PR though, we want to keep it

edc/Dockerfile Outdated Show resolved Hide resolved
edc/Dockerfile Outdated Show resolved Hide resolved
edc/README.md Outdated
@@ -0,0 +1,8 @@
# EDC Connector Image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention that it is not part of SDP. Please coordinate with @stackfab or @stefanigel on wording

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've labelled it as a "technology preview" component

@fhennig
Copy link
Contributor Author

fhennig commented Aug 16, 2023

@lfrancke Any particular reason you commented on this now?

@lfrancke
Copy link
Member

I received a notification. Probably because you merged main

@fhennig fhennig marked this pull request as draft August 16, 2023 13:04
@fhennig fhennig marked this pull request as ready for review August 21, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants