Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Druid image to use a builder step and apply all around best practices #441

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lfrancke
Copy link
Member

Description

This is similar to the recent PRs for Hadoop and Airflow

  • It splits up building in two steps which saves a bit of space in the final image and makes the Dockerfile more readable (don't care about number of layers in intermediate builder)
  • It adds --fail to all curl commands to fail if a download fails
  • Sets environment variables

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant