Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Revert "Add proper startup, liveness and readiness probes (#273)" #276

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Revert "Add proper startup, liveness and readiness probes (#273)" #276

wants to merge 1 commit into from

Conversation

sbernauer
Copy link
Member

This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Revert "Add proper startup, liveness and readiness probes (#273)"
cc6902d 
This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.
@sbernauer sbernauer requested a review from fhennig July 27, 2022 09:28
@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 27, 2022
@sbernauer
Revert "Add proper startup, liveness and readiness probes (#273)" (#276)
f9511bf 
This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.
@bors
Copy link
Contributor

bors bot commented Jul 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Revert "Add proper startup, liveness and readiness probes (#273)" [Merged by Bors] - Revert "Add proper startup, liveness and readiness probes (#273)" Jul 27, 2022
@bors bors bot closed this Jul 27, 2022
@bors bors bot deleted the revert-probes branch July 27, 2022 09:39
@lfrancke lfrancke linked an issue Aug 12, 2022 that may be closed by this pull request
Add correct probes to Druid containers #142
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add correct probes to Druid containers
2 participants
@sbernauer @fhennig