[Merged by Bors] - LDAP authentication #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2023
sbernauer
previously requested changes
Jan 11, 2023
tests/templates/kuttl/ldap-authentication/02-install-hdfs.yaml.j2
Outdated
Show resolved
Hide resolved
sbernauer
reviewed
Jan 12, 2023
This was referenced Jan 12, 2023
vsupalov
force-pushed
the
feature/144-ldap-authentication-v2
branch
from
1c4fed7
to
0961a12
Compare
vsupalov
force-pushed
the
feature/144-ldap-authentication-v2
branch
from
0961a12
to
c161c00
Compare
vsupalov
commented
Jan 24, 2023
added 3 commits
January 24, 2023 16:48
spoiler: it does not seem to be allowed by druid
fhennig
previously approved these changes
Jan 25, 2023
|
Alright, thanks for the review folks! I will rebase and merge this branch once the release is through. I will create a comment on the main issue with the findings from this stage, so we can keep track of follow-up tasks there. |
|
That run had the wrong operator version selected. New one: https://ci.stackable.tech/job/druid-operator-it-custom/71/ |
maltesander
reviewed
Jan 30, 2023
|
A list of follow-up tickets, also posted in the main LDAP issue: |
vsupalov
dismissed
sbernauer’s stale review
Thanks! All changes have been implemented, and the PR has one approval. Merging time!
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
# Description This will resolve part of #144 The ticket can be merged once the stretch goals are reached as well. A new iteration on the changes prototyped in #341 This iteration will include: * A closer resemblance to the ticket requirements - using a list of authenticators * Non-usage of LDAP for inter-node authentication (basic authentication instead) * Erroring out if both TLS auth and LDAP auth are configured ## Follow-up Work * Interconnection with an OPA authorization config, if provided (former stretch goal) * Adding ldaps:// support (former stretch goal) * Druid does not like anonymous LDAP access (without bind credentials). I have not found a way to configure it. This however, seems to be a usecase we want to support generally.
|
Here we goooo |
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will resolve part of #144
The ticket can be merged once the stretch goals are reached as well.
A new iteration on the changes prototyped in #341
This iteration will include:
Follow-up Work
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information