Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Enable logging #407

Closed
wants to merge 28 commits into from
Closed

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Feb 27, 2023

Description

Add log aggregation

Closes #364

Integration tests

Build Status

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber self-assigned this Feb 27, 2023
@siegfriedweber siegfriedweber marked this pull request as ready for review February 28, 2023 11:03
@vsupalov vsupalov mentioned this pull request Feb 28, 2023
7 tasks
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, will continue tomorrow!

rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 1, 2023
# Description

Add log aggregation
@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable logging [Merged by Bors] - Enable logging Mar 1, 2023
@bors bors bot closed this Mar 1, 2023
@bors bors bot deleted the enable-logging branch March 1, 2023 11:23
bors bot pushed a commit that referenced this pull request Mar 6, 2023
# Description

During resolving conflicts between #407 and #408 this line was not removed, thus creating (and overwriting!) the truststore *after* the ldap tls cert was added. Result was the ldap tls cert missing from the truststore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable Log Aggregation for Druid
2 participants