-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for gitlab and github and safer token storage #766
base: main
Are you sure you want to change the base?
Conversation
@D-Byte - Great work on this! I noticed you're importing useCredentials in the hooks section, but it's not being used as a hook. To improve the implementation, could you: Wrap these functions into a custom hook Let me know if you'd like help with the implementation. |
@thecodacus, Thanks is it maybe an idea that i put all the git stuf in a lib and also the auth stuf in a lib? So that these can scale more easy the git related things in there? |
this makes more sense, thanks. |
also one thing is bugging me whats the point of encrypting if the key to decryption is also stored in browser? |
@thecodacus You are right but my reasoning was some encryption is better than none. But for most cases its safer than a normal cookie. The local storage is protected by the Same-Origin Policy. For now I think this is a little better. I first wanted to have this function with GitLab and GitHub working. The encryption is some extra that need some extra attention later on, maybe some other community user has a bright idea about it. I am now going to test if pulling and pushing to GitHub works. |
@D-Byte I really like this PR however can you please run pnpm typecheck and fix the errors |
I am moving some things around again to make the code more flexible so it can host other git providers without breaking. |
@thecodacus, @dustinwloring1988 I think its ready for testing, it only do some basic pull, push and commit (create, update) |
looks good so far, I am not able to connect to gitlab though, even after adding api, write_repository, scopes will test again, and if all look good will target for 0.0.5 release |
Updated version after commit dustinwloring1988:feat/enhanced-github-connection
Secure Git Credentials Management System
Overview
Implemented a secure credential management system for GitHub and GitLab integrations, featuring encrypted storage and seamless authentication handling.
Key Features
Technical Implementation
UI/UX Improvements
GitHub setup form
GitLab setup form
Only show push to ... button when there are credentials set.