Skip to content

Commit

Permalink
fix nightly building fatimage in ci, revert to matrix.build
Browse files Browse the repository at this point in the history
  • Loading branch information
bertiethorpe committed Nov 15, 2024
1 parent 4a3f195 commit 097cdae
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/fatimage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
openstack:
name: openstack-imagebuild
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os_version }} # to branch/PR + OS
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os_version }}-${{ matrix.build }} # to branch/PR + OS + build
cancel-in-progress: true
runs-on: ubuntu-22.04
strategy:
Expand All @@ -24,6 +24,8 @@ jobs:
os_version:
- RL8
- RL9
build:
- openstack.openhpc
env:
ANSIBLE_FORCE_COLOR: True
OS_CLOUD: openstack
Expand All @@ -37,7 +39,6 @@ jobs:
"openstack.openhpc": "rocky-latest-RL9"
}
}
BUILD: openstack.openhpc
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -83,13 +84,13 @@ jobs:
PACKER_LOG=1 packer build \
-on-error=${{ vars.PACKER_ON_ERROR }} \
-only=${{ env.BUILD }} \
-only=${{ matrix.build }} \
-var-file=$PKR_VAR_environment_root/${{ env.CI_CLOUD }}.pkrvars.hcl \
-var "source_image_name=${{ env.SOURCE_IMAGE }}" \
openstack.pkr.hcl
env:
PKR_VAR_os_version: ${{ matrix.os_version }}
SOURCE_IMAGE: ${{ fromJSON(env.SOURCE_IMAGES_MAP)[matrix.os_version][env.BUILD] }}
SOURCE_IMAGE: ${{ fromJSON(env.SOURCE_IMAGES_MAP)[matrix.os_version][matrix.build] }}

- name: Get created image names from manifest
id: manifest
Expand All @@ -106,7 +107,7 @@ jobs:
- name: Upload manifest artifact
uses: actions/upload-artifact@v4
with:
name: image-details-${{ env.BUILD }}-${{ matrix.os_version }}
name: image-details-${{ matrix.build }}-${{ matrix.os_version }}
path: |
./image-id.txt
./image-name.txt
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/nightlybuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
openstack:
name: openstack-imagebuild
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os_version }} # to branch/PR + OS
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os_version }}-${{ matrix.build }} # to branch/PR + OS + build
cancel-in-progress: true
runs-on: ubuntu-22.04
strategy:
Expand All @@ -26,6 +26,8 @@ jobs:
os_version:
- RL8
- RL9
build:
- openstack.rocky-latest
env:
ANSIBLE_FORCE_COLOR: True
OS_CLOUD: openstack
Expand All @@ -35,7 +37,6 @@ jobs:
"RL8": "Rocky-8-GenericCloud-Base-8.9-20231119.0.x86_64.qcow2",
"RL9": "Rocky-9-GenericCloud-Base-9.4-20240523.0.x86_64.qcow2"
}
BUILD: openstack.openhpc
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -81,7 +82,7 @@ jobs:
PACKER_LOG=1 packer build \
-on-error=${{ vars.PACKER_ON_ERROR }} \
-only=${{ env.BUILD }} \
-only=${{ matrix.build }} \
-var-file=$PKR_VAR_environment_root/${{ env.CI_CLOUD }}.pkrvars.hcl \
-var "source_image_name=${{ env.SOURCE_IMAGE }}" \
openstack.pkr.hcl
Expand Down

0 comments on commit 097cdae

Please sign in to comment.