Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval details for rego constraints. #4730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Oct 11, 2024

Summary

This PR makes rego/constraints evaluation engine uniform with the rest of the rules using templates for evaluation details failures.

Fixes stacklok/minder-stories#43

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This PR makes `rego/constraints` evaluation engine uniform with the
rest of the rules using templates for evaluation details failures.
@blkt blkt self-assigned this Oct 11, 2024
@eleftherias
Copy link
Member

@blkt could you link the commit to the user story https://github.com/stacklok/minder-stories/issues/43?

@blkt
Copy link
Contributor Author

blkt commented Oct 11, 2024

@eleftherias I was not aware of the story, this commit does not resolve it.
Edit: I forgot an important "not" in the previous statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants