Attempt to limit loop execution when instance is created successfully

stackrox · Jun 5, 2024 · 9a2e54a · 9a2e54a
1 parent acc800b
commit 9a2e54a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/ansible/roles/create-vm/tasks/create-s390x-vm.yml b/ansible/roles/create-vm/tasks/create-s390x-vm.yml
@@ -76,6 +76,9 @@
       - ibm_output_inventory_file != ""
     delegate_to: localhost
 
+  - set_fact:
+      instance_created: true
+
   rescue:
     - name: Check if VSI was created
       ibm.cloudcollection.ibm_is_instance_info:

diff --git a/ansible/roles/create-vm/tasks/main.yml b/ansible/roles/create-vm/tasks/main.yml
@@ -14,19 +14,20 @@
     excluded: "{{ vm_image in excluded_vms }}"
   when: vm_image is defined and excluded == false
 
+- set_fact:
+    instance_created: false
+
 - block:
   - name: Create IBM Z VM
     include_tasks: create-s390x-vm.yml
     vars:
       vsi_name: "{{ vm_name }}"
       vsi_zone: "{{ zone.name }}"
       vsi_subnet_id: "{{ zone.subnet_id }}"
-      condition: "{{ (instance_result | default({'changed': false })).changed }}"
-    when: vm_arch == "s390x" and not condition
+    when: vm_arch == "s390x" and not instance_created
     loop: "{{ s390x.zones }}"
     loop_control:
       loop_var: zone
-    register: instance_result
 
   - name: Create IBM POWER VM
     include_tasks: create-ppc64le-vm.yml