Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches to using buildx properly for multi-arch #1307

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Aug 24, 2023

Description

In theory this is a simpler mechanism for multi-arch but may be slower since each arch is built in sequence. To counteract this a little, each container is now built in parallel

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
rhel.rhel-8 ebpf 215.208 232.503 204.92 213.7 🟢
ubuntu-os.ubuntu-2004-lts ebpf 227.655 249.467 236.1 234.97 🟢
ubuntu-os.ubuntu-2204-lts ebpf 232.863 262.903 222.56 229.05 🟢

Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

There is just the question of the grpc-mock image bump. If this let's your s390x attempt pass, that would be a good reason to keep it 😉

@Stringy Stringy marked this pull request as ready for review August 24, 2023 16:09
@Stringy Stringy requested a review from a team as a code owner August 24, 2023 16:09
@Stringy Stringy merged commit 993fefe into master Aug 25, 2023
101 of 115 checks passed
@Stringy Stringy deleted the giles/integration-test-containers-proper-buildx branch August 25, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants