Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable s390x testing #1308

Merged
merged 39 commits into from
Sep 10, 2023
Merged

Enable s390x testing #1308

merged 39 commits into from
Sep 10, 2023

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Aug 24, 2023

Description

Enables s390x testing, with the inclusion of the new multi-arch testing containers.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Relying on CI

@Stringy Stringy added run-cpaas-steps Trigger CI steps related to cPaaS skip-multiarch-builds labels Aug 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
ubuntu-os.ubuntu-2204-lts ebpf 234.509 258.227 222.56 229.05 🟢

Base automatically changed from giles/integration-test-containers-proper-buildx to master August 25, 2023 08:40
@Stringy Stringy mentioned this pull request Aug 29, 2023
Merged
5 tasks
@Stringy Stringy added run-multiarch-tests run-cpaas-steps Trigger CI steps related to cPaaS and removed skip-multiarch-builds labels Aug 31, 2023
@Stringy Stringy changed the base branch from master to mauro/full-multiarch-images August 31, 2023 11:25
@Stringy Stringy marked this pull request as ready for review August 31, 2023 12:05
@Stringy Stringy requested a review from a team as a code owner August 31, 2023 12:05
@Stringy Stringy changed the base branch from mauro/full-multiarch-images to master August 31, 2023 12:11
@Stringy Stringy changed the base branch from master to mauro/full-multiarch-images August 31, 2023 12:54
@Stringy Stringy mentioned this pull request Sep 4, 2023
Merged
2 tasks
Base automatically changed from mauro/full-multiarch-images to master September 4, 2023 08:37
@Stringy
Give s390x hosts a friendlier name and move the vars file around
f5e064f
@Stringy
Correct setting of collector image
d61216d
@Stringy
Delegate tag make to localhost..
fdfb851
@Stringy
Debug s390x VM tests
0b1fc95
@Stringy
Cleanup for review
192bafb
@Stringy
Fix missing proc scrape for new test mechanism
a8788e2
@Stringy
Adds rhel-s390x to cpaas integration tests
181945b
@Stringy
Fixes cpaas integration test image
096a83d
@Stringy
Fix IBM inventory
40da5e1
@Stringy
Revert to using correct tag
274422e
@Stringy
Incorporate full multi-arch images
7a29956
@Stringy
Fix rebase mistakes...
5deb7af
@Stringy
Multi-arch collector-slim pull in cpaas
7f524d2
@Stringy
Fix multi-arch tags for full images
8e5db5c
@Stringy
Let playbook handle arch
f9e42ab
@Stringy
Return single layer depth for amd64
eec2e7b
@Stringy
Needs a string apparently
5674ec0
@Stringy
Remove multi-arch tests from normal integration test run
a015c3d
@Stringy
Makes multiarch tests its own job
8749568
@Stringy
Tidy up from PR review
47d003b
@Stringy
Reinstates block list for s390x eBPF
ad2edc9
@Stringy
Makes benchmarks skip in test short mode
7ae90df
Molter73
Molter73 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stringy Stringy removed the run-cpaas-steps Trigger CI steps related to cPaaS label Sep 10, 2023
@Stringy Stringy merged commit a67257a into master Sep 10, 2023
88 of 91 checks passed
@Stringy Stringy deleted the giles/enable-s390x-testing branch September 10, 2023 18:57
@Stringy Stringy restored the giles/enable-s390x-testing branch October 3, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

Assignees
No one assigned
Labels
build-full-images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stringy @Molter73