Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes integration tests on noexec mounted directories #1318

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Sep 11, 2023

Description

With the tests now running directly on the host, some hosts mount /tmp noexec which means we get permission denied errors when trying to run the integration tests from that location. This PR changes the location to the user's home directory to avoid the noexec constraint.

Longer term, tests should be containerized to avoid this issue altogether

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Tested locally against garden linux, will rely on CI to test the remainder of the platforms.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue

@Stringy Stringy merged commit 85ad93a into master Sep 11, 2023
43 checks passed
@Stringy Stringy deleted the giles/fix-integration-tests-noexec-tmp branch September 11, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants