Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19721: block modules for RHEL >= 8.9 #1332

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ovalenti
Copy link
Contributor

Description

RHEL8.9 received backports which breaks the probe's kernel-version-adaptation-macros for most versions.
This PR blocks modules from RHEL8.9 and onwards.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ovalenti ovalenti marked this pull request as ready for review September 15, 2023 16:03
@ovalenti ovalenti requested a review from a team as a code owner September 15, 2023 16:03
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for blocking these drivers

Comment on lines +7 to +8
# ROX-19721: RHEL8.9 breaks modules
~4.18.0-(?:50[89]|5[1-9][0-9]|[6-9][0-9]{2})\.el8\.x86_64 * mod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] We usually add things to the bottom of the file so we know where to look for things that are newer and where to look for things that might not be relevant anymore, but it's fine this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ok, I take note. I was trying to get kernels in increasing version and keep RHEL stuff together 😅

@ovalenti ovalenti merged commit 332115f into master Sep 18, 2023
120 of 140 checks passed
@ovalenti ovalenti deleted the ovalenti/rhel89_block_modules branch September 18, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants