ROX-19899: Implement SuiteSetup recovery to encapsulate critical cleanup #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringy
force-pushed
the
giles/ROX-14542-no-more-boltdb
branch
from
021eacb
to
41c64c1
Compare
Stringy
force-pushed
the
giles/ROX-14542-guarantee-test-cleanup
branch
from
4cb00d0
to
c21d7e6
Compare
|
Stringy
changed the title
Stringy
force-pushed
the
giles/ROX-14542-guarantee-test-cleanup
branch
from
2b0fce7
to
5fb19b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testify does not currently support guaranteed execution of
TearDownSuite(see issue stretchr/testify#1123) This PR provides a function that wraps common and critical teardown code that has historically affected our tests considerably.In particular:
This will mean that even if a test setup fails, subsequent tests should have the same "clean slate," and won't fail.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Tested locally, using normal test execution and with a forced panic