Pull all test images to avoid timing issues during tests #1349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will pre-pull test images on CI to make test execution times more consistent. There is currently a situation where test setup might start various containers and then wait to pull an image. When the timing of events is important/crucial, this waiting can cause flakes.
This behaviour is disabled when running individual test suites because the upfront performance penalty is significant at that level. I have yet to figure out a neat way of only pulling the images that the requested test uses, but that can be looked at in a follow up if it is deemed useful.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Tested locally, with timings: