Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes expect logging clearer when more events are reveived than expected #1351

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Makes expect logging clearer when more events are reveived than expected #1351

merged 1 commit into from
Oct 3, 2023

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Oct 3, 2023

Description

Improves the logging output for clarity in scenarios where number of events received exceeds the expected number.

Before:

only retrieved 4 processes, expected 3

After

found 4 processes (expected 3)

@Stringy Stringy requested a review from a team as a code owner October 3, 2023 09:09
Molter73
Molter73 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM!!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue

@Stringy Stringy merged commit be7c111 into master Oct 3, 2023
43 checks passed
@Stringy Stringy deleted the giles/improve-assert-logging branch October 3, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stringy @Molter73