Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump disk size for s390x VM when running in dev mode #1384

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Oct 23, 2023

Description

IBM cloud VMs are created with 10GB disks by default, this is enough for our tests but it's also a heavy limitation when trying to use one of these VMs for dev work. This patch bumps the size of the created disk to 20GB, which is not huge, but enough for creating a few images and running some tests.

Checklist

  • Investigated and inspected CI test results

Testing Performed

  • Create a VM manually and check its disk size is 20GB.

@Molter73 Molter73 requested a review from a team as a code owner October 23, 2023 13:23
@Molter73 Molter73 requested a review from Stringy October 23, 2023 13:23
@github-actions
Copy link

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
ubuntu-os.ubuntu-2004-lts ebpf 231.111 247.611 236.1 234.97 🟢

Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Molter73 Molter73 merged commit 2407d9b into master Oct 30, 2023
40 checks passed
@Molter73 Molter73 deleted the mauro/s390x/bump-disk-on-dev branch October 30, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants