Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiarch full image builds on PRs #1389

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Oct 24, 2023

Description

There's a bug when building full multiarch images on PRs. The bucket used for pulling drivers is changed in the main CI workflow to use a staging bucket, but the main CI never pushes drivers for P/Z to this bucket, so it fails because it find no drivers to add into the image. Changing to the staging bucket should only be done by the CPaaS workflow, so an additional condition for this is added.

Checklist

  • Investigated and inspected CI test results

Testing Performed

  • Run CI with build-full-images, run-multiarch-builds and run-cpaas-steps. Ensure all used buckets are the expected ones.

There's a bug when building full multiarch images on PRs. The bucket
used for pulling drivers is changed in the main CI workflow to use a
staging bucket, but the main CI never pushes drivers for P/Z to this
bucket, so it fails because it find no drivers to add into the image.
Changing to the staging bucket should only be done by the CPaaS
workflow, so an additional condition for this is added.
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Molter73 Molter73 added build-full-images run-cpaas-steps Trigger CI steps related to cPaaS run-multiarch-builds Run steps for non-x86 archs. and removed do-not-merge/work-in-progress labels Oct 24, 2023
@Molter73 Molter73 marked this pull request as ready for review October 24, 2023 15:46
@Molter73 Molter73 requested a review from a team as a code owner October 24, 2023 15:46
@github-actions
Copy link

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
ubuntu-os.ubuntu-2004-lts ebpf 232.584 260.21 236.1 234.97 🟢

@Molter73 Molter73 merged commit e9b0ae0 into master Nov 9, 2023
212 of 243 checks passed
@Molter73 Molter73 deleted the mauro/fix-full-images-pr branch November 9, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-full-images run-cpaas-steps Trigger CI steps related to cPaaS run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants