Remove CORE_BPF available message on Power machines #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on Power machines, we are wrongly printing a message stating that CORE_BPF is available on the platform, but we don't support it in code, so we shouldn't be printing the message. Additionally, setting CORE_BPF as the collection method should hard fail since it is unsupported.
ovalenti
previously approved these changes
Oct 25, 2023
erthalion
reviewed
Oct 25, 2023
ovalenti
dismissed
their stale review
Afterthough, we probably should use a build-time check instead
This would be fine, but compile time checks are usually not as nice to read. If this was in a hot path or compilation absolutely depended on the change I'd 100% use a build-time check, but since this is not the case, I think an explicit runtime check is better. |
|
erthalion
approved these changes
Oct 25, 2023
|
Merging now since the integration tests will not be affected by this change and I'd like to start cutting our release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running on Power machines, we are wrongly printing a message stating that CORE_BPF is available on the platform, but we don't support it in code, so we shouldn't be printing the message. Additionally, setting CORE_BPF as the collection method should hard fail since it is unsupported.
Checklist
Testing Performed
Will try to test this on a power VM, but the change is small enough that should be good enough to be merged as is IMO.